Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add z_bytes example #325

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Sep 17, 2024

Based on #322

@wyfo wyfo requested a review from Mallets September 17, 2024 20:22
Copy link
Contributor

PR missing one of the required labels: {'new feature', 'dependencies', 'enhancement', 'breaking-change', 'bug', 'internal', 'documentation'}

@wyfo wyfo added the documentation Improvements or additions to documentation label Sep 17, 2024
@Mallets
Copy link
Member

Mallets commented Sep 18, 2024

An example of Protobuf serialization is missing and it should be added as per eclipse-zenoh/zenoh#1418

@wyfo
Copy link
Contributor Author

wyfo commented Sep 18, 2024

Protobuf requires to install additional dependencies, and contrary to Rust, this is not done automatically. Also, protobuf for Python is not like Prost, it requires to generate code and compile binary from a proto file.
All this process is quite heavy, and not automatic, that's why I've not included protobuf

@Mallets
Copy link
Member

Mallets commented Sep 18, 2024

Protobuf is a widely-used serialization library and we have received many questions on how to use Protobuf with Zenoh.
We should provide an example.

Copy link
Member

@Mallets Mallets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve and merge this PR so as to already provide a set of examples for serialization/deserialization with ZBytes. However, a follow-up PR should following including Protobuf.

@Mallets Mallets merged commit 49d19d5 into eclipse-zenoh:main Sep 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants