Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bridge has a
namespace
configuration that was only used as namespace for thezenoh_bridge_ros2dds
node.This PR prefixes all the Zenoh key expressions used for routes with the configured
namespace
.As a consequence, with a bridge configured with
bot1
as namespace:cmd_vel
will be exposed in Zenoh asbot1/cmd_vel
bot1
namespace will route the Zenoh key exprbot1/cmd_vel
as a ROS2 topiccmd_vel
.bot1/cmd_vel
as a ROS2 topicbot1/cmd_vel
In case of multiple robots, this allows to keep the ROS2 nodes running in each robot untouched, without namespace remapping. Then, a control host has the choice:
bot1/cmd_vel
)