Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support '--ros-args -r' for __node and __ns #58

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Support '--ros-args -r' for __node and __ns #58

merged 1 commit into from
Jan 17, 2024

Conversation

JEnoch
Copy link
Member

@JEnoch JEnoch commented Jan 16, 2024

Add the parsing of --ros-args command line arguments as per specification from https://design.ros2.org/articles/ros_command_line_arguments.html.
And manage the -r,--remap <from:=to> arguments only for namespace (from == '__ns') and node name (from == __node).

Closes #48

@JEnoch JEnoch requested a review from p-avital January 16, 2024 16:37
Copy link

@p-avital p-avital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JEnoch JEnoch merged commit 0600020 into main Jan 17, 2024
9 checks passed
@JEnoch JEnoch deleted the fix_48 branch January 23, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support --ros-args -r __node:= command line arg
2 participants