Simplified load plugin #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JEnoch
approved these changes
Jan 29, 2024
JEnoch
requested changes
Jan 30, 2024
There was a problem hiding this comment.
Similarly to your change in zenoh-plugin-dds, the README.md "How to build it" chapter should be updated to remove the warning wrt. cargo build without -p.
I suggest to further simplify it instructing to just run cargo build --release (without -p ...) and describing the 2 resulting artifacts (lib plugin and bridge exe).
JEnoch
requested changes
Jan 30, 2024
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update according to eclipse-zenoh/zenoh#583