Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ROS 2 service in CI #357

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Conversation

evshary
Copy link
Contributor

@evshary evshary commented Dec 11, 2024

Extend the test scope of CI. Now we can test ROS 2 service and client with Zenoh querier and queryable

Copy link

PR missing one of the required labels: {'enhancement', 'breaking-change', 'dependencies', 'new feature', 'internal', 'documentation', 'bug'}

@evshary evshary added the internal Changes not included in the changelog label Dec 11, 2024
@evshary evshary requested a review from JEnoch December 11, 2024 05:44
@JEnoch
Copy link
Member

JEnoch commented Dec 11, 2024

#359 must be addressed before merging this PR

@evshary evshary changed the base branch from use_querier to main December 11, 2024 14:11
@evshary
Copy link
Contributor Author

evshary commented Dec 11, 2024

Let's target on main branch and I'm exploring a better way for this

@evshary evshary marked this pull request as draft December 12, 2024 05:38
@evshary
Copy link
Contributor Author

evshary commented Dec 12, 2024

Covert it back to draft and wait until the PR is merged
#362

@evshary evshary marked this pull request as ready for review December 13, 2024 07:38
@evshary
Copy link
Contributor Author

evshary commented Dec 13, 2024

@JEnoch I think it's ready to review now. Thank you!

Signed-off-by: ChenYing Kuo <[email protected]>
Copy link
Member

@JEnoch JEnoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JEnoch JEnoch merged commit 04c7884 into eclipse-zenoh:main Dec 16, 2024
8 checks passed
@evshary evshary deleted the support_service_ci branch December 16, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants