Fix NodeInfo update after Reader discovery #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing the code, I spotted an inconsistency in code reacting to the discovery of a DDS Reader and updating the NodeInfo object:
node.update_with_writer(&reader);was called instead ofnode.update_with_reader(&reader);AFAICT this bug was only affecting the view of what has been discovered for a Node in the admin space, and only in the case the bridge received the
ros_discovery_infomessage declaring the Reader before discovering this DDS Reader.This case probably rarely occurs.