Use new Serialization and zenoh-ext API #279
Conversation
|
PR missing one of the required labels: {'enhancement', 'breaking-change', 'bug', 'dependencies', 'new feature', 'documentation', 'internal'} |
Charles-Schleich
added
enhancement
| @@ -228,16 +228,22 @@ impl CddsRequestHeader { | |||
| buf[16] = self.is_little_endian as u8; | |||
|
|
|||
| hashmap.insert(ATTACHMENT_KEY_REQUEST_HEADER, buf); | |||
There was a problem hiding this comment.
I'm not sure why a hashmap was used... probably for ease of serialization via ZBytes::from_iter(hashmap.iter()).
But now that this ease is gone, I don't see the point of this hashmap. We could just do:
writer.append(ZBytes::from(ATTACHMENT_KEY_REQUEST_HEADER));
writer.append(ZBytes::from(buf));
writer.finish();There was a problem hiding this comment.
Removed Hashmap, packing bytes directly.
| } | ||
| } | ||
|
|
||
| impl TryFrom<&ZBytes> for CddsRequestHeader { | ||
| type Error = ZError; | ||
|
|
||
| fn try_from(value: &ZBytes) -> Result<Self, Self::Error> { | ||
| let hashmap: HashMap<[u8; 3], [u8; 17]> = |
There was a problem hiding this comment.
On receiving side, we expect the the attachment value to contain only:
- the
ATTACHMENT_KEY_REQUEST_HEADER - the header (16 bytes)
Rather than using a hashmap, we could just do:
- try to read
len(ATTACHMENT_KEY_REQUEST_HEADER)bytes (returnErrif fail) - check if those bytes are equal to
ATTACHMENT_KEY_REQUEST_HEADER(returnErrif fail) - try to read 16 bytes (return
Errif fail)
There was a problem hiding this comment.
Reading Bytes from slice, failing if not enough bytes are found or if bytes do not match ATTACHMENT_KEY_REQUEST_HEADER values.
Porting Ros2dds plugin over to new Serialization API
Tracking issue
eclipse-zenoh/zenoh#1474
Note: update Dependencies when eclipse-zenoh/zenoh#1473 is merged