Fix -i / --id option: remap it to the ZenohID #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mallets
reviewed
Aug 30, 2024
Co-authored-by: Luca Cominardi <[email protected]>
Mallets
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #179 the
idconfiguration have been removed from the plugin configuration. Then the-i/--idoption was returning an error.This PR re-map the
-i/--idoption of the bridge to the Zenoh ID configuration for its Session.As a consequence the id can no longer be a free string, but must be a lowercase hexadecimal string with 32 characters maximum (128 bits maximum for a Zenoh ID). It must be unique in the system (i.e. not the same id for 2 bridges).