-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ROS2-like Rust Examples #104
Conversation
@imstevenpmwork If this pull request contains a bugfix or a new feature, then please consider using |
1 similar comment
@imstevenpmwork If this pull request contains a bugfix or a new feature, then please consider using |
@JEnoch I tested these in my vm. Could you review these before I move to the CPP ones 😄 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples are working fine 👍
Please address my review comments and complete the README.md
similarly to Python's one (adding build instructions)
Question: why did you move the Python scripts into a src
subdirectory ?
There is no need for this, and the zenoh-python examples are not in a src
subdirectory.
Thanks for the feedback! |
@JEnoch Anything missing in this PR to merge the rust examples into the examples branch? |
This adds ROS2-like examples written in Rust for:
Plus slight modifications to the Python ones. Mostly related to directory structure and logs.
Resolves #70
Main PR: #80