Skip to content

Commit

Permalink
Incorporate the review comments from Julien
Browse files Browse the repository at this point in the history
Signed-off-by: ChenYing Kuo <[email protected]>
  • Loading branch information
evshary committed Dec 5, 2024
1 parent 5bb9dd7 commit a01e1cc
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ jobs:
- name: Run tests
run: cargo test --verbose

build_test_ros2_humble:
system_tests_with_ros2_humble:
name: System tests with ROS 2 Humble
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-jammy-ros-humble-ros-base-latest
Expand All @@ -82,7 +83,8 @@ jobs:
shell: bash
run: "source /opt/ros/humble/setup.bash && cargo test --features ros_test --verbose"

build_test_ros2_jazzy:
system_tests_with_ros2_jazzy:
name: System tests with ROS 2 Jazzy
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-noble-ros-jazzy-ros-base-latest
Expand Down
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ futures = "0.3.26"
git-version = "0.3.5"
hex = "0.4.3"
lazy_static = "1.4.0"
r2r = "0.9"
regex = "1.7.1"
rustc_version = "0.4"
serde = "1.0.154"
Expand Down
2 changes: 1 addition & 1 deletion zenoh-plugin-ros2dds/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ futures = { workspace = true }
git-version = { workspace = true }
hex = { workspace = true }
lazy_static = { workspace = true }
r2r = { version = "0.9", optional = true }
r2r = { workspace = true, optional = true }
regex = { workspace = true }
serde = { workspace = true }
serde_json = { workspace = true }
Expand Down

0 comments on commit a01e1cc

Please sign in to comment.