Support for MQTTS #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l TLS (mTLS) support. Error handling is still to be implemented.
|
@gmartin82 If this pull request contains a bugfix or a new feature, then please consider using |
JEnoch
requested changes
Feb 27, 2024
There was a problem hiding this comment.
This looks great overall!
Just 2 improvements are required:
- the config shall also support inline certificates (to simplify management in Zetta platform)
- as a consequence those config parameter shall be managed as secrets no never appear in the admin space.
Please have a look to how this was done for Zenoh config in eclipse-zenoh/zenoh#577
…e64 encoded format.
|
@JEnoch I've made the requested changes. The bridge only allows files to be specified via the command line but base64 encoded certificates can be provided in the plugin configuration. |
JEnoch
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for MQTTS including both sever-authentication and mutual TLS (mTLS) support.
Closes #3.