Implement condition variables for Mbed and FreeRTOS-Plus-TCP ports #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'breaking-change', 'new feature', 'documentation', 'bug', 'enhancement', 'dependencies', 'internal'} |
Co-Authored-By: Alexander Bushnev <[email protected]>
|
PR missing one of the required labels: {'enhancement', 'bug', 'documentation', 'dependencies', 'breaking-change', 'new feature', 'internal'} |
|
PR missing one of the required labels: {'bug', 'documentation', 'internal', 'breaking-change', 'enhancement', 'dependencies', 'new feature'} |
|
PR missing one of the required labels: {'documentation', 'new feature', 'bug', 'internal', 'breaking-change', 'dependencies', 'enhancement'} |
|
PR missing one of the required labels: {'documentation', 'dependencies', 'bug', 'new feature', 'breaking-change', 'internal', 'enhancement'} |
sashacmc
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of condition variables in mbed port is completely broken. The ConditionVariable class can't be used with z_condvar APIs as it requires passing a Mutex in the constructor. I got "inspired" by the implementation of this class and wrote a custom condition variable implementation that works with z_condvar interfaces. I also adapted this implementation for FreeRTOS-Plus-TCP port.