Rework attachments #423
Merged
Rework attachments #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you review this one @sashacmc? |
jean-roland
force-pushed
the
ft_attachment
branch
from
75afe45 to
05a53e9
Compare
jean-roland
force-pushed
the
ft_attachment
branch
from
05a53e9 to
4f4b952
Compare
sashacmc
reviewed
Jun 17, 2024
| /** | ||
| * Enable attachments. | ||
| */ | ||
| #ifndef Z_FEATURE_ATTACHMENT |
There was a problem hiding this comment.
Maybe I missed something, but why the attachment now not a feature and can’t be disabled to reduce code size?
There was a problem hiding this comment.
With the change, the impact on code size should be minimal since all the code is now on the API, and it shouldn't be linked if not used by the application.
So I believe we should remove this token so users have one less config option to worry about
sashacmc
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 1.0, attachments are a simple payload internally and the key, value pair serialization must be done at the app level through the zenoh API. Task list: