Issue/api sync #61
Merged
Issue/api sync #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fuzzypixelz Can you please review? 😄 |
Mallets
approved these changes
Mar 21, 2024
Mallets
pushed a commit
that referenced
this pull request
Apr 15, 2024
* feat(examples arguments): Adding CLI args to ZSub. * feat(examples arguments): Adding CLI args to ZPub. * feat(examples arguments): Adding CLI args to ZGet. * feat(examples arguments): Adding CLI args to ZPut. * feat(examples arguments): Adding attachment argument for ZGet. * feat(examples arguments): CLI arguments for ZDelete. * feat(examples arguments): CLI arguments for ZPubThr. * feat(examples arguments): CLI arguments for ZSubThr. * feat(examples arguments): CLI arguments for ZQueryable. * feat(examples arguments): tidying up code * feat(examples arguments): updating README * Add the missing trait * Cargo fmt * Update Cargo.lock to include the fix of binding interface * Typo * Trigger CI * Issue/api sync (#61) * Adapt JNI codebase to recent Zenoh changes. * issue(api sync): removing publisher.write() after it was removed from the Rust API * feat(examples arguments): Adding CLI args to ZSub. * feat(examples arguments): Adding CLI args to ZPub. * feat(examples arguments): Adding CLI args to ZGet. * feat(examples arguments): Adding CLI args to ZPut. * feat(examples arguments): Adding attachment argument for ZGet. * feat(examples arguments): CLI arguments for ZDelete. * feat(examples arguments): CLI arguments for ZPubThr. * feat(examples arguments): CLI arguments for ZSubThr. * feat(examples arguments): CLI arguments for ZQueryable. * feat(examples arguments): tidying up code * feat(examples arguments): updating README * Add the missing trait * Cargo fmt * Typo * Trigger CI * Removing unused import * feat(examples arguments): replacing multiple arguments format for the listen and connect arguments. For instance: gradle ZPub --args="-l tcp/localhost:7447 tcp/localhost:7448 tcp/localhost:7449" now becomes gradle ZPub --args="-l tcp/localhost:7447 -l tcp/localhost:7448 -l tcp/localhost:7449" --------- Co-authored-by: yuanyuyuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Kotlin API
In this PR we remove the
publisher.write(value, sampleKind)function from the API since it was removed on Zenoh Rust.Fixes #60