Springboot native lib loading: fallback to javaClass classloader #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystem class loader failure
|
PR missing one of the required labels: {'breaking-change', 'new feature', 'bug', 'enhancement', 'internal', 'dependencies', 'documentation'} |
DariusIMP
added
bug
milyin
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: when exporting a JAR of a springboot project using Zenoh-Kotlin as a dependency, the native library failed to be loaded.
Fix: fallback to javaClass classloader for loading native lib in case of system class loader failure.
Tested: tested manually on a springboot project and on a non springboot project.
Related to eclipse-zenoh/zenoh-java#153