Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(publication): modifying workflows to publish snapshot packages #27

Merged
merged 2 commits into from
Feb 7, 2024
Merged

build(publication): modifying workflows to publish snapshot packages #27

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e411f95
build(publication): modifying workflows to publish snapshot packages
DariusIMP Jan 24, 2024
b364ff4
build(publication): modifying workflows to publish snapshot packages 2
DariusIMP Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,26 @@ jobs:
steps:
- name: Check whether all jobs pass
run: echo '${{ toJson(needs) }}' | jq -e 'all(.result == "success")'

# Publish snapshot packages. These jobs will only be triggered when the CI is executed on main.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much slower will the CI be because of this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publications tend to take around 10 minutes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that almost doubles it, making it ~20mins. I don't see it as particularly problematic. But we can always do it later on a nightly basis if it turns out to be too long.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far the cron job is set to be run at 6am, I think it's ok, if not we can change it later as you say.

publish_jvm_snapshot_package:
name: Publish JVM snapshot package
if: github.ref == 'refs/heads/main'
needs: ci
uses: ./.github/workflows/publish_jvm.yml
permissions:
contents: read
packages: write
with:
version: 0.11.0-rc-SNAPSHOT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is technically valid semver, it is quite confusing (i.e. being a snapshot of a release candidate). I suggest going with 0.11.0-SNAPSHOT in this case, as it means roughly the same thing as 0.11.0-dev.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting from the next release, we will drop the -rc pre-release identifier so we should be doing major.minor.patch-SNAPSHOT anyway.


publish_android_snapshot_package:
name: Publish Android snapshot package
if: github.ref == 'refs/heads/main'
needs: ci
uses: ./.github/workflows/publish_android.yml
permissions:
contents: read
packages: write
with:
version: 0.11.0-rc-SNAPSHOT
9 changes: 8 additions & 1 deletion .github/workflows/publish_android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ name: Publish Android
on:
release:
types: [published]
workflow_call:
inputs:
version:
required: false
type: string
description: 'The publication version'
default: '0.11.0-rc'
DariusIMP marked this conversation as resolved.
Show resolved Hide resolved
workflow_dispatch:

env:
Expand Down Expand Up @@ -52,6 +59,6 @@ jobs:
- name: Gradle Publish Android Package
uses: gradle/gradle-build-action@v2
with:
arguments: publishAndroidReleasePublicationToGithubPackagesRepository
arguments: publishAndroidReleasePublicationToGithubPackagesRepository -PzkVersion=${{ inputs.version }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
9 changes: 8 additions & 1 deletion .github/workflows/publish_jvm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ name: Publish JVM
on:
release:
types: [published]
workflow_call:
inputs:
version:
required: false
type: string
description: 'The publication version'
default: '0.11.0-rc'
workflow_dispatch:

env:
Expand Down Expand Up @@ -156,6 +163,6 @@ jobs:
- name: Gradle Publish JVM Package
uses: gradle/gradle-build-action@v2
with:
arguments: publishJvmPublicationToGithubPackagesRepository
arguments: publishJvmPublicationToGithubPackagesRepository -PzkVersion=${{ inputs.version }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion zenoh-kotlin/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
//

group = "io.zenoh"
version = "0.11.0-dev"
version = project.findProperty("zkVersion") as String? ?: "0.11.0-dev"
DariusIMP marked this conversation as resolved.
Show resolved Hide resolved

plugins {
id("com.android.library")
Expand Down
Loading