Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization alignment #268

Merged
merged 16 commits into from
Oct 17, 2024

Conversation

DariusIMP
Copy link
Member

@DariusIMP DariusIMP commented Oct 17, 2024

  • Removing ZBytes.from and into.ZBytes functions.
  • Removing override of ZBytes.toString(), instead zDeserialize<String>(zbytes) must be invoked
  • Enabling recursive serialization and deserialization through zSerialize and zDeserialize for nested types.
  • Fix incompatibility of serialization and deserialization between Kotlin and Rust

@DariusIMP DariusIMP requested a review from wyfo October 17, 2024 05:25
Copy link

PR missing one of the required labels: {'documentation', 'dependencies', 'internal', 'bug', 'breaking-change', 'enhancement', 'new feature'}

@DariusIMP DariusIMP added enhancement New feature or request release Part of the next release labels Oct 17, 2024
@DariusIMP DariusIMP requested a review from Mallets October 17, 2024 05:28
@DariusIMP DariusIMP removed the request for review from Mallets October 17, 2024 06:14
@DariusIMP DariusIMP marked this pull request as draft October 17, 2024 06:14
DariusIMP and others added 3 commits October 17, 2024 04:22
@wyfo
Copy link
Contributor

wyfo commented Oct 17, 2024

Code and documentation needs to be polished, but in the meantime serialization tests are passing, so LGTM

@fuzzypixelz fuzzypixelz marked this pull request as ready for review October 17, 2024 11:21
@Mallets Mallets merged commit 562fb7b into eclipse-zenoh:main Oct 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release Part of the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants