Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api sync #246

Merged
merged 10 commits into from
Oct 1, 2024
Merged

Api sync #246

merged 10 commits into from
Oct 1, 2024

Conversation

DariusIMP
Copy link
Member

@DariusIMP DariusIMP commented Sep 27, 2024

Adapting serialization api after changes from eclipse-zenoh/zenoh#1473.

Items:

  • Extracting serialize and deserialize from ZBytes
  • Adapting the JNI code to the new serialization api
  • Removing custom deserialization map

@DariusIMP DariusIMP requested a review from wyfo September 27, 2024 20:37
Copy link

PR missing one of the required labels: {'breaking-change', 'enhancement', 'internal', 'dependencies', 'documentation', 'bug', 'new feature'}

@DariusIMP DariusIMP added release Part of the next release internal Changes not included in the changelog labels Sep 27, 2024
@DariusIMP DariusIMP requested a review from milyin September 27, 2024 21:30
…, renaming serialize into zSerialize and deserialize into zDeserialize.
@DariusIMP
Copy link
Member Author

DariusIMP commented Sep 30, 2024

Depends on eclipse-zenoh/zenoh#1473

Edit:

Once that PR is merged, we need to revert the Cargo.toml changes so that it points back to eclipse-zenoh.

Done

@DariusIMP DariusIMP marked this pull request as ready for review October 1, 2024 09:14
@milyin milyin merged commit adbb6e5 into eclipse-zenoh:main Oct 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes not included in the changelog release Part of the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants