fix(mem leak): user attachment bytes not being freed (#48)

eclipse-zenoh · Mar 6, 2024 · 4d3d46a · 4d3d46a
1 parent 0bb75c9
commit 4d3d46a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/zenoh-jni/src/query.rs b/zenoh-jni/src/query.rs
@@ -293,6 +293,9 @@ pub(crate) fn on_query(
     _ = env
         .delete_local_ref(payload)
         .map_err(|err| log::error!("Error deleting local ref: {}", err));
+    _ = env
+        .delete_local_ref(attachment_bytes)
+        .map_err(|err| log::error!("Error deleting local ref: {}", err));
     result
 }
 

diff --git a/zenoh-jni/src/reply.rs b/zenoh-jni/src/reply.rs
@@ -103,6 +103,9 @@ fn on_reply_success(
     _ = env
         .delete_local_ref(byte_array)
         .map_err(|err| log::debug!("Error deleting local ref: {}", err));
+    _ = env
+        .delete_local_ref(attachment_bytes)
+        .map_err(|err| log::debug!("Error deleting local ref: {}", err));
     result
 }
 

diff --git a/zenoh-jni/src/subscriber.rs b/zenoh-jni/src/subscriber.rs
@@ -154,6 +154,9 @@ pub(crate) unsafe fn declare_subscriber(
             _ = env
                 .delete_local_ref(byte_array)
                 .map_err(|err| log::debug!("Error deleting local ref: {}", err));
+            _ = env
+                .delete_local_ref(attachment_bytes)
+                .map_err(|err| log::debug!("Error deleting local ref: {}", err));
         })
         .reliability(reliability)
         .res();