Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wall time in throughput test #91

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

jean-roland
Copy link
Contributor

This fixes throughput test using system time instead of wall time, which is what we want.

@milyin milyin self-requested a review December 20, 2023 22:10
Copy link
Contributor

@milyin milyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the one hand I like this idea: the code becomes more C++ style and uses right tool for the purpose. On the other hand this example matches equal example in zenoh-c (https://github.com/eclipse-zenoh/zenoh-c/blob/master/examples/z_sub_thr.c), so it's better to use exactly the same measuring method. On the third hand :-) the corresponding Rust test works in the rust's way to measure the time, so why not to do in here in C++ way.

Anyway it's better to 1) make sure that measuring results are the same and 2) integrate it after the release

@jean-roland
Copy link
Contributor Author

We deviate from zenoh-c but we're now closer to the zenoh-cpp own zenoh-ping example. Anyway, I verified that the measurements were correct and I'm ok with integrating this after the release.

@milyin milyin merged commit 191ef4c into eclipse-zenoh:main Dec 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants