Preserve String Length When Pushing String Temporary Containing Null Char

[connoranderson]

I was running some demo / example code, and serializing protobuf data. I noticed that sometimes, when the payload data contained byte \0, the subscriber would fail to parse.

This difference can easily be seen by comparing the bytes received when doing these two approaches

// APPROACH 1, remaining bytes are lost
session.put("my/topic", std::string("Hello\0World", 11));

// APPROACH 2, remaining bytes are not lost
auto str = std::string("Hello\0World", 11);
session.put("my/topic", str);

Upon further investigation, I saw that the handling of Bytes object construction differed depending on construction from temporary string std::string&& and string ref std::string&. It appears that we are converting here to char* without preserving the length of the original string, which causes the remaining bytes including the first \0 to be lost.

[github-actions]

PR missing one of the required labels: {'bug', 'new feature', 'documentation', 'enhancement', 'breaking-change', 'internal', 'dependencies'}

[DenisBiryukov91]

Hello @connoranderson . Thanks for your PR. Would it be possible for you to sign eclipse eca https://www.eclipse.org/legal/eca/ ?

[connoranderson]

Hello @connoranderson . Thanks for your PR. Would it be possible for you to sign eclipse eca https://www.eclipse.org/legal/eca/ ?

Verifying with employer. Let me get back to you on that, likely after holidays.