Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addes missing include to zshm #342

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Dec 19, 2024

Related with this issue in rmw_zenoh_cpp ros2/rmw_zenoh#350 when building in ubuntu 20.04

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Copy link

PR missing one of the required labels: {'dependencies', 'new feature', 'internal', 'breaking-change', 'bug', 'documentation', 'enhancement'}

@YuanYuYuan
Copy link
Contributor

LGTM.

@YuanYuYuan
Copy link
Contributor

BTW, I found that https://github.com/include-what-you-use/include-what-you-use can detect this. Do we consider including this in our CI? @DenisBiryukov91

/home/circle/Workings/ZettaScale/project/zenoh-rmw/src/zenoh-cpp/include/zenoh/api/shm/buffer/zshm.hxx should add these lines:
#include <stdint.h>           // for uint8_t
#include <zenoh_concrete.h>   // for Z_OK
#include <zenoh_macros.h>     // for z_move, z_loan_mut
#include <cstddef>            // for size_t
#include <functional>         // for reference_wrapper, ref
#include <utility>            // for move
#include "zenoh.h"            // for z_shm_clone, z_shm_data, z_shm_from_mut

/home/circle/Workings/ZettaScale/project/zenoh-rmw/src/zenoh-cpp/include/zenoh/api/shm/buffer/zshm.hxx should remove these lines:

The full include-list for /home/circle/Workings/ZettaScale/project/zenoh-rmw/src/zenoh-cpp/include/zenoh/api/shm/buffer/zshm.hxx:
#include <stdint.h>           // for uint8_t
#include <zenoh_concrete.h>   // for Z_OK
#include <zenoh_macros.h>     // for z_move, z_loan_mut
#include <cstddef>            // for size_t
#include <functional>         // for reference_wrapper, ref
#include <optional>           // for optional, nullopt, nullopt_t
#include <utility>            // for move
#include "../../base.hxx"     // for Owned, null_object_t
#include "../../interop.hxx"  // for as_loaned_c_ptr, as_owned_cpp_ref
#include "zenoh.h"            // for z_shm_clone, z_shm_data, z_shm_from_mut
#include "zshmmut.hxx"        // for ZShmMut
---

@milyin milyin merged commit 964b64d into eclipse-zenoh:main Dec 20, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants