add support for transferring data ownership to Bytes via custom deleter #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nit: shall we align with the doc in zenoh-c? https://github.com/eclipse-zenoh/zenoh-c/blob/8974132e1bd49954ebf0a7b6242c8c3f8d21f503/include/zenoh_commons.h#L1480-L1482 |
I added to the docs, that deleter should be a thread safe. There is no need for extra mention for NULL, since Deleter can not be null here and should always a valid callable. It can have an empty implementation if user desires (it is way simpler to provide it in c++ than in c) |
fuzzypixelz
approved these changes
Dec 18, 2024
milyin
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for transferring data ownership to Bytes via custom deleter