Add clone method to Reply #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
|
PR missing one of the required labels: {'internal', 'dependencies', 'bug', 'new feature', 'documentation', 'enhancement', 'breaking-change'} |
include/zenoh/api/reply.hxx
Outdated
| @@ -84,6 +84,16 @@ class Reply : public Owned<::z_owned_reply_t> { | |||
| return {}; | |||
| } | |||
| #endif | |||
|
|
|||
| /// @brief Construct a a shallow copy of this Reply. | |||
| /// This can be used, to send reply replies outside of ``Queryable`` callback. | |||
There was a problem hiding this comment.
the documentation is wrong, since it is describes the behavior of Query clone.
There was a problem hiding this comment.
Can you help me with right documentation here ?
There was a problem hiding this comment.
I think just /// @brief Construct a a shallow copy of this Reply. should be good enough.
There was a problem hiding this comment.
Sorry, could you also remove an extra a before shallow_copy ?
DenisBiryukov91
added
enhancement
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
milyin
requested changes
Nov 25, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
milyin
approved these changes
Nov 25, 2024
DenisBiryukov91
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add clone method to Reply
Required here https://github.com/ros2/rmw_zenoh/pull/311/files