Shm mutation example #861
Merged
Shm mutation example #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Few API improvements Add missing mutable accessor 'z_sample_payload_mut'
…ZBytes where needed)
yellowhatter
added
enhancement
| @@ -60,6 +60,17 @@ pub extern "C" fn z_reply_err_payload(this_: &z_loaned_reply_err_t) -> &z_loaned | |||
| this_.as_rust_type_ref().payload().as_loaned_c_type_ref() | |||
| } | |||
|
|
|||
| /// Returns mutable reply error payload. | |||
| #[no_mangle] | |||
| pub extern "C" fn z_reply_err_payload_mut( | |||
There was a problem hiding this comment.
There is no way to get mutable err or mutable sample from the reply, so this method is useless for now.
There was a problem hiding this comment.
Then we should add this. SHM buffer may reside literally everywhere where ZBytes is
|
Could you also add docs for all new functions. |
Conflicts: Cargo.lock build-resources/opaque-types/Cargo.lock
- review fix for function doc
done |
DenisBiryukov91
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shm mutation example + some API additions for mutable accesses