Support for zenoh features #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'bug', 'documentation', 'enhancement', 'internal', 'new feature', 'breaking-change', 'dependencies'} |
DenisBiryukov91
force-pushed
the
support-for-zenoh-features
branch
from
5195843 to
e62e278
Compare
yellowhatter
requested changes
Sep 24, 2024
| - name: Run clippy | ||
| run: cargo clippy --all-targets --all-features -- --deny warnings | ||
| - name: Run clippy without default features | ||
| run: cargo clippy --all-targets --no-default-features --features unstable,shared-memory -- --deny warnings |
There was a problem hiding this comment.
if "without default features" then why unstable and shared-memory features are enabled?
There was a problem hiding this comment.
Default features are those of zenoh, so we do not really have any code behind them - so clippy will only lint zenoh code (also --all-features does not work on windows). On the other hand we have a lot of zenoh-c code behind unstable and shared-memory features which we want to lint.
CMakeLists.txt
Outdated
| if (("${cargo_flags}" MATCHES ^.*shared-memory.*$) AND NOT(ZENOHC_BUILD_WITH_SHARED_MEMORY)) | ||
| set(ZENOHC_BUILD_WITH_SHARED_MEMORY TRUE) | ||
| message(STATUS "Due to ZENOHC_CARGO_FLAGS setting ZENOHC_BUILD_WITH_SHARED_MEMORY = TRUE") | ||
| elseif(ZENOHC_BUILD_WITH_SHARED_MEMORY) |
There was a problem hiding this comment.
Conditions can be simplified:
if(ZENOHC_BUILD_WITH_SHARED_MEMORY)
...
elseif("${cargo_flags}" MATCHES ^.*shared-memory.*$)
...
endif()
CMakeLists.txt
Outdated
| set(cargo_flags ${cargo_flags} --features=shared-memory) | ||
| endif() | ||
|
|
||
| if(ZENOHC_BUILD_WITH_UNSTABLE_API) | ||
| if (("${cargo_flags}" MATCHES ^.*unstable.*$) AND NOT(ZENOHC_BUILD_WITH_UNSTABLE_API)) |
yellowhatter
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for zenoh features
Closes #626