Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uninit Handler and Closure in z_pull #671

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Fix uninit Handler and Closure in z_pull #671

merged 2 commits into from
Sep 11, 2024

Conversation

fuzzypixelz
Copy link
Member

Trying to use z_pull results in:

Opening session...
Declaring Subscriber on 'demo/example/**'...
Press <enter> to pull data...
fish: Job 1, '../target/debug/examples/z_pull' terminated by signal SIGSEGV (Address boundary error)

We might want to define channel capacity constants akin to (unless they're already there and I failed to find them):

https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/src/api/session.rs#L106-L111

@fuzzypixelz fuzzypixelz added the bug Something isn't working label Sep 11, 2024
Mallets
Mallets reviewed Sep 11, 2024
View reviewed changes
examples/z_pull.c Outdated Show resolved Hide resolved
@fuzzypixelz fuzzypixelz requested a review from Mallets September 11, 2024 11:57
@Mallets Mallets merged commit a59ae52 into main Sep 11, 2024
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

@sashacmc sashacmc Awaiting requested review from sashacmc

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuzzypixelz @Mallets