Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding complete option to publication_cache #243

Merged
merged 10 commits into from
Feb 15, 2024
Merged

adding complete option to publication_cache #243

merged 10 commits into from
Feb 15, 2024

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Feb 8, 2024 •
edited
Loading

@eclipse-zenoh-bot
Copy link
Contributor

@milyin If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@milyin milyin marked this pull request as draft February 8, 2024 17:50
@milyin milyin self-assigned this Feb 8, 2024
@milyin milyin mentioned this pull request Feb 8, 2024
Open
3 tasks
@milyin milyin marked this pull request as ready for review February 12, 2024 13:48
@milyin milyin requested a review from Mallets February 12, 2024 13:50
Mallets
Mallets reviewed Feb 12, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Feb 12, 2024
View reviewed changes
include/zenoh_commons.h Outdated Show resolved Hide resolved
Mallets
Mallets requested changes Feb 12, 2024
View reviewed changes
Copy link
Member

@Mallets Mallets left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the documentation typo. All the rest LGTM.

Mallets
Mallets reviewed Feb 12, 2024
View reviewed changes
Cargo.toml.in Show resolved Hide resolved
Mallets
Mallets reviewed Feb 12, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Feb 12, 2024
View reviewed changes
src/info.rs Outdated Show resolved Hide resolved
@milyin milyin merged commit de57b3f into main Feb 15, 2024
9 checks passed
@milyin milyin deleted the pubcache_complete branch February 15, 2024 10:27
@Yadunund Yadunund mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees

@milyin milyin

Labels
None yet
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose completeness option in PublicationCach in Rust, C, C++
4 participants
@milyin @eclipse-zenoh-bot @Mallets @oteffahi