add C function to register callback for matching subscribers #236
Conversation
|
Thanks @filippobrizzi for your PR. To be able to merge any PR you'd need to sign first the Eclipse Contribution Agreement. @p-avital and @milyin would you mind having a look at this PR? |
I created an account at https://accounts.eclipse.org/, but I did not receive any confirmation email and cannot login. Do you know if the server is down or something? |
|
I don't know tbh. But make sure that you used the same email address as the one used in GitHub for this PR. The Eclipse tool's checks require the email address to be the same. |
There was a problem hiding this comment.
Hi,
Thank you for your contribution. This seems sound to me.
However, we still consider that API to be unstable, so the prefix for all things pertaining to it should be zcu (c for "zenoh-c exclusivity" and u for "unstable"). I've marked every symbol that should be renamed with a "zcu" comment to help you track them all down :)
filippobrizzi
force-pushed
the
matching_listener
branch
from
ec33a29 to
80a6c97
Compare
filippobrizzi
force-pushed
the
matching_listener
branch
from
80a6c97 to
424102b
Compare
| /// After a move, `val` will still exist, but will no longer be valid. The destructors are double-drop-safe, but other functions will still trust that your `val` is valid. | ||
| /// | ||
| /// To check if `val` is still valid, you may use `z_X_check(&val)` or `z_check(val)` if your compiler supports `_Generic`, which will return `true` if `val` is valid. | ||
| #[repr(C, align(8))] |
There was a problem hiding this comment.
@p-avital here I followed what was done for the other struct like z_owned_subscriber_t but for it there is a differentiation for arm. Am I supposed to add it also here? How can I test it?
@p-avital Thanks for the feedback, I have completed the refactor. |
Add
z_publisher_matching_listener_callbackfunction to register user callback when the publisher connects or disconnects to subscribers.To complete exposing the full functionality I'll add
z_publisher_matching_listener_callbackThis will allow to expose
recv_async.