New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement `z_take` for `z_loaned_xxx_t*`, pass mutable loaned in callbacks #658

Closed

milyin opened this issue Sep 6, 2024 · 2 comments

Labels

api fix enhancement release

Contributor

milyin commented Sep 6, 2024

implement z_take methods for mutably loaned types z_loan_xxx_t* (coordinate exact naming with pico)
pass z_loan_xxx_t* to callbacks (instead of const z_load_xxx_t*), allowing user to take ownership of the owned object by z_take or keep ownership for caller. This will make clone unnecessary for callbacks.

The text was updated successfully, but these errors were encountered:

milyin added this to Zenoh 1.0.0 release

milyin added enhancement api fix release labels

Contributor

DenisBiryukov91 commented Sep 9, 2024 •

edited

Loading

Is it really needed given that we decided to keep clone functionality for sample/query/reply ?

Contributor Author

milyin commented Sep 9, 2024

after eclipse-zenoh/zenoh#1383 no need to do this

milyin closed this as completed

github-project-automation bot moved this to Done in Zenoh 1.0.0 release

milyin reopened this

milyin closed this as not planned

milyin mentioned this issue

align clone methods: coordination task eclipse-zenoh/zenoh#1372

Closed

12 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment