fix(commons): do not fail without Vars section
#257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `Vars` section was not present in a file that is parsed by the function `try_parse_from_file` then an error would be thrown. This commit changes the behaviour of the function such that if it is missing, no error is returned and instead a log message is recorded. * Cargo.lock: added dependency `tracing`. * zenoh-flow-commons/Cargo.toml: added dependency `tracing`. * zenoh-flow-commons/src/utils.rs: instead of throwing an error if the `Vars` section is missing, log a debug message and continue the normal execution. Signed-off-by: Julien Loudet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
Varssection was not present in a file that is parsed by the functiontry_parse_from_filethen an error would be thrown.This commit changes the behaviour of the function such that if it is missing, no error is returned and instead a log message is recorded.
Cargo.lock: added dependency
tracing.zenoh-flow-commons/Cargo.toml: added dependency
tracing.zenoh-flow-commons/src/utils.rs: instead of throwing an error if the
Varssection is missing, log a debug message and continue the normal execution.