Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added local install path for libraries and new run command function #50

Closed
wants to merge 1 commit into from

Conversation

riley206
Copy link

The run_command function allows you to pass a list of commands into the active environment. Using this you can add things to the config store, and much more.

@@ -405,6 +405,33 @@ def get_agent_by_identity(self, identity):
if agent.get('identity') == identity:
return agent

def run_command(self, command: list):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnessary we already have an environment setup that has a run in it.

If you look at the install_agent it uses the appropriate environment and simply calls the run command. Please try and have the same structure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or was this so that I could use it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self._virtual_env.run(args=cmd, capture=True, cwd=self.volttron_home) from inside the platform wrapper does this exact same thing as this command.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You told me to add this. This allows everyone to easily just run a command in their test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad...I was talking about the install_config_entry function.

@@ -405,6 +405,33 @@ def get_agent_by_identity(self, identity):
if agent.get('identity') == identity:
return agent

def run_command(self, command: list):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or was this so that I could use it?

@@ -405,6 +405,33 @@ def get_agent_by_identity(self, identity):
if agent.get('identity') == identity:
return agent

def run_command(self, command: list):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self._virtual_env.run(args=cmd, capture=True, cwd=self.volttron_home) from inside the platform wrapper does this exact same thing as this command.

@craig8
Copy link
Contributor

craig8 commented Oct 29, 2024

Follow on PR #53

@craig8 craig8 closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants