Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress exception if download fails and file is present #22

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

BjoernAtBosch
Copy link
Member

This commit suppresses an exception is throw if obtain_local_file_path is called with an url, no internet connections is available (i.e. being offline), and a (cached) local file already exists.

@BjoernAtBosch BjoernAtBosch requested review from MP91 and doosuu and removed request for MP91 August 28, 2024 16:01
velocitas_lib/__init__.py Show resolved Hide resolved
velocitas_lib/__init__.py Show resolved Hide resolved
Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BjoernAtBosch BjoernAtBosch merged commit 6085c1b into main Aug 29, 2024
5 checks passed
@BjoernAtBosch BjoernAtBosch deleted the velocitas_offline branch August 29, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants