Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dynamic versioning should cut off initial v on prefixed semver #70

Merged
merged 4 commits into from
Sep 14, 2023
Merged

fix: Dynamic versioning should cut off initial v on prefixed semver #70

merged 4 commits into from
Sep 14, 2023

Conversation

doosuu
Copy link
Member

@doosuu doosuu commented Sep 14, 2023

Describe your changes

Cut off initial v on tags if they represent a semver.

Issue ticket number and link

Checklist - Manual tasks

  • Examples are executing successfully
  • Created/updated unit tests. Code Coverage percentage on new code shall be >= 80%.
  • Created/updated integration tests.
  • Devcontainer can be opened successfully
  • Devcontainer can be opened successfully behind a corporate proxy
  • Devcontainer can be re-built successfully
  • Extended the documentation (e.g. README.md, CONTRIBUTING.md, Velocitas)

@doosuu doosuu force-pushed the fix-dynamic-versioning branch 2 times, most recently from 54caa0e to ff56903 Compare September 14, 2023 11:46
@doosuu doosuu requested review from kse3hi and BjoernAtBosch and removed request for kse3hi September 14, 2023 12:12
BjoernAtBosch
BjoernAtBosch reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small finding

conanfile.py Outdated Show resolved Hide resolved
BjoernAtBosch
BjoernAtBosch approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doosuu doosuu merged commit 8ef265d into main Sep 14, 2023
3 checks passed
@doosuu doosuu deleted the fix-dynamic-versioning branch September 14, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BjoernAtBosch BjoernAtBosch BjoernAtBosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doosuu @BjoernAtBosch