Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Adapt examples to app manifest v3 #67

Merged
merged 5 commits into from
Aug 22, 2023
Merged

feature: Adapt examples to app manifest v3 #67

merged 5 commits into from
Aug 22, 2023

Conversation

doosuu
Copy link
Member

@doosuu doosuu commented Aug 18, 2023 •
edited
Loading

Describe your changes

Adaption of the examples for app manifest v3.

Issue ticket number and link

Checklist - Manual tasks

  • Examples are executing successfully
  • Created/updated unit tests. Code Coverage percentage on new code shall be >= 80%.
  • Created/updated integration tests.
  • Devcontainer can be opened successfully
  • Devcontainer can be opened successfully behind a corporate proxy
  • Devcontainer can be re-built successfully
  • Extended the documentation (e.g. README.md, CONTRIBUTING.md, Velocitas)

MP91
MP91 requested changes Aug 18, 2023
View reviewed changes
examples/seat-adjuster/AppManifest.json Outdated Show resolved Hide resolved
examples/seat-adjuster/AppManifest.json Outdated Show resolved Hide resolved
examples/set-data-points/AppManifest.json Outdated Show resolved Hide resolved
examples/seat-adjuster/AppManifest.json Show resolved Hide resolved
@doosuu doosuu changed the title Adapt examples feature: Adapt examples to app manifest v3 Aug 19, 2023
BjoernAtBosch
BjoernAtBosch approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MP91
MP91 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doosuu doosuu merged commit 3e3ae3b into main Aug 22, 2023
2 checks passed
@doosuu doosuu deleted the adapt-to-manifest-v3 branch August 22, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BjoernAtBosch BjoernAtBosch BjoernAtBosch approved these changes

@MP91 MP91 MP91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doosuu @MP91 @BjoernAtBosch