Skip to content

Commit

Permalink
Give job write permission
Browse files Browse the repository at this point in the history
Also updating dependency to get rid of Node.js 16 actions
Also updating timelimit to consider long-time builds
  • Loading branch information
erikbosch committed Jun 12, 2024
1 parent e0e6ca3 commit 2abffb3
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
git config --global --add safe.directory $( pwd )
- name: Identify changes in devenv repo
uses: dorny/paths-filter@v2
uses: dorny/paths-filter@v3
id: changesInPath
with:
filters: |
Expand Down
16 changes: 13 additions & 3 deletions src/cpp-app/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ on:
release:
types: [published, edited]

# Needed if GITHUB_TOKEN by default do not have right to create release
permissions:
contents: write
packages: write

jobs:

get-app-name:
Expand Down Expand Up @@ -76,7 +81,12 @@ jobs:
with:
checkName: Merge Trivy results
token: ${{ secrets.GITHUB_TOKEN }}
timeoutSeconds: 1800
# This workflow does not trigger a build, instead it relies on that a successful build
# exists for this commit. If triggering this workflow just after a new commit has been
# uploaded we will need to wait for the "Merge Trivy results" to finish
# Building the default C++ App on Github may take long time, 70 minutes observed
# Setting limit to 100 minutes to have some margin
timeoutSeconds: 6000
intervalSeconds: 20

- name: Download builds from Build multiarch image workflow artifacts
Expand Down Expand Up @@ -145,7 +155,7 @@ jobs:
path: generated_md

- name: Setup Hugo
uses: peaceiris/actions-hugo@v2
uses: peaceiris/actions-hugo@v3
with:
hugo-version: "0.89.4"
extended: true
Expand Down Expand Up @@ -222,7 +232,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Publish to GH Pages
uses: peaceiris/actions-gh-pages@v3
uses: peaceiris/actions-gh-pages@v4
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ${{github.workspace}}/hugo/public
Expand Down
4 changes: 2 additions & 2 deletions src/python-app/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ jobs:
templatePath: ./.github/actions/templates

- name: Setup Hugo
uses: peaceiris/actions-hugo@v2
uses: peaceiris/actions-hugo@v3
with:
hugo-version: "0.89.4"
extended: true
Expand Down Expand Up @@ -242,7 +242,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Publish to GH Pages
uses: peaceiris/actions-gh-pages@v3
uses: peaceiris/actions-gh-pages@v4
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ${{github.workspace}}/hugo/public
Expand Down
5 changes: 5 additions & 0 deletions src/python-sdk/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ on:
release:
types: [published, edited]

# Needed if GITHUB_TOKEN by default do not have right to create release
permissions:
contents: write
packages: write

jobs:
release-package:
name: Generate package binaries
Expand Down

0 comments on commit 2abffb3

Please sign in to comment.