Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache temporary redirections in the original location (#4459) #4547

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kysmith-csg
Copy link
Contributor

Some p2 sites can temporarily redirect to another location. In the case of JFrog Artifactory, these redirection URLs are too long to make as a file path, so the build would fail in this case. For temporary redirects, we save the artifact in the original location instead, since it's likely the redirection might change in the future. Permanent redirects will get their own cache entry as before.

Copy link

Test Results

  603 files  ±0    603 suites  ±0   4h 16m 38s ⏱️ + 9m 10s
  432 tests ±0    420 ✅  - 4   7 💤 ±0  1 ❌ ±0  4 🔥 +4 
1 296 runs  ±0  1 266 ✅  - 7  22 💤 ±0  1 ❌ ±0  7 🔥 +7 

For more details on these failures and errors, see this check.

Results for commit df64a9b. ± Comparison against base commit edb9113.

@kysmith-csg
Copy link
Contributor Author

Text not found in log: No repository found at http://localhost:49744/repoB
org.apache.maven.it.VerificationException: Text not found in log: No repository found at http://localhost:49744/repoB
	at org.apache.maven.it.Verifier.verifyTextInLog(Verifier.java:351)
	at org.eclipse.tycho.test.tycho2938.ContentJarTest.redirectToBadLocation(ContentJarTest.java:89)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

We get various other errors, but not this one :(

Running locally I get these three:

  1. Failed to load p2 metadata repository from location http://localhost:57700/repoB
  2. Unable to read repository at http://localhost:57700/repoB
  3. http://localhost:57700/repoB is not a valid repository location

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant