-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump org.eclipse.jdt:ecj from 3.38.0 to 3.40.0 #4497
Merged
github-actions
merged 7 commits into
tycho-4.0.x
from
dependabot/maven/tycho-4.0.x/org.eclipse.jdt-ecj-3.40.0
Dec 6, 2024
Merged
Bump org.eclipse.jdt:ecj from 3.38.0 to 3.40.0 #4497
github-actions
merged 7 commits into
tycho-4.0.x
from
dependabot/maven/tycho-4.0.x/org.eclipse.jdt-ecj-3.40.0
Dec 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot
bot
added
backport
dependencies
Pull requests that update a dependency file
labels
Dec 3, 2024
Test Results 600 files 600 suites 4h 9m 53s ⏱️ Results for commit 0b4828d. ♻️ This comment has been updated with latest results. |
Bumps [org.eclipse.jdt:ecj](https://github.com/eclipse-jdt/eclipse.jdt.core) from 3.38.0 to 3.40.0. - [Commits](https://github.com/eclipse-jdt/eclipse.jdt.core/commits) --- updated-dependencies: - dependency-name: org.eclipse.jdt:ecj dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/maven/tycho-4.0.x/org.eclipse.jdt-ecj-3.40.0
branch
from
December 4, 2024 09:19
2683ed4
to
7939bd5
Compare
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/maven/tycho-4.0.x/org.eclipse.jdt-ecj-3.40.0
branch
from
December 5, 2024 20:55
7939bd5
to
17e4c94
Compare
akurtakov
force-pushed
the
dependabot/maven/tycho-4.0.x/org.eclipse.jdt-ecj-3.40.0
branch
from
December 6, 2024 06:40
17e4c94
to
18d2e7c
Compare
Using 17 as preferred target in non compiler specific tests to prevent having to do similar update soon. Updates o.e.jdt.core to the version signed with same certificate.
This fixes warnings during build like: ``` [WARNING] location of system modules is not set in conjunction with -source 17 not setting the location of system modules may lead to class files that cannot run on JDK 17 --release 17 is recommended instead of -source 17 -target 17 because it sets the location of system modules automatically ``` and also ensures usage of newer API doesn't slip in.
akurtakov
force-pushed
the
dependabot/maven/tycho-4.0.x/org.eclipse.jdt-ecj-3.40.0
branch
from
December 6, 2024 07:00
223fb6a
to
331e223
Compare
Tycho currently contains some so called "Mojo Testcases" that are ones that (partly) simulate the execution of a mojo, but these have some problems: 1) They currently depend on heavy outdated (and deprecated) maven-plugin-testharness 2) They often do not have a full test setup so we need to have some quirks in the code (e.g components are null) 3) They are often hard to understand as they are a mixture of (incomplete) maven setups with things setup in the code 4) We even have some constructors only used to support these cases 5) As they often test very specific internal behavior they often need adjustments. 6) For the Maven 4 transition one needs to adjust them to new maven4 api and components and executions. On the other hand we have a very good integration suite that is made of actual executable examples and test, changing internal implementation details does not affect these or show clear use-cases that break. Because of this and to prepare for the Maven 4 transition these tests are now deleted.
akurtakov
force-pushed
the
dependabot/maven/tycho-4.0.x/org.eclipse.jdt-ecj-3.40.0
branch
from
December 6, 2024 07:23
54393b5
to
f54027f
Compare
This fixes warnings during build like: ``` [WARNING] location of system modules is not set in conjunction with -source 17 not setting the location of system modules may lead to class files that cannot run on JDK 17 --release 17 is recommended instead of -source 17 -target 17 because it sets the location of system modules automatically ``` and also ensures usage of newer API doesn't slip in.
Unfortunately those values are not interchangeable anymore, when using the release attribute.
dependabot
bot
deleted the
dependabot/maven/tycho-4.0.x/org.eclipse.jdt-ecj-3.40.0
branch
December 6, 2024 09:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps org.eclipse.jdt:ecj from 3.38.0 to 3.40.0.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)