Always use full-named o.e.equinox.launcher artifact

[HannesWell]

For for Mac OS X there was no equinox-launcher fragment for CARBON with full name, i.e. with .. suffix, but only a org.eclipse.equinox.launcher.carbon.macosx fragment. But since Eclipse 4.2, released 2012, CARBON is not supported anymore at all [1]. Therefore the code adjust to that special naming schema, which also imposed difficulties or new supported architectures on Macos should be removed.

See also eclipse-equinox/equinox#622

[1] - https://download.eclipse.org/eclipse/updates/4.2/R-4.2-201206081400

[github-actions]

Test Results

  594 files    594 suites   4h 4m 26s ⏱️
  422 tests   413 ✅  7 💤 1 ❌ 1 🔥
1 266 runs  1 242 ✅ 22 💤 1 ❌ 1 🔥

For more details on these failures and errors, see this check.

Results for commit d2ffb78.

[laeubi]

@HannesWell before being too much concerned you should check if the method is actually of any use today, as the DepedencyWalker is to be removed and beside one place should be unused anyways.

[HannesWell]

From the callers it looks like only BuildQualifierAggregatorMojo uses it at:

tycho/tycho-packaging-plugin/src/main/java/org/eclipse/tycho/buildversion/BuildQualifierAggregatorMojo.java

Line 85 in cf559c6

projectType.getDependencyWalker(thisProject).walk(new ArtifactDependencyVisitor() {

While I'm not so much concerned about the qualifier of a feature, I wonder if it would still break a build if the short-named launcher fragment is removed one day? Because without this, when build a product for mac the computation of its qualifier will probably fail, given it uses dependency-walker/visitor:

tycho/tycho-core/src/main/java/org/eclipse/tycho/core/ArtifactDependencyVisitor.java

Lines 34 to 37 in cf559c6

	public void missingPlugin(PluginRef ref, List<ArtifactDescriptor> walkback) {
	throw newRuntimeException("Could not resolve plugin", ref.toString(), walkback);
	}

But I'm not sure if that is really used.

[HannesWell]

Btw. are the test failures related to this change? They looks somewhat unrelated.

[HannesWell]

Thinking again about the current only usage (determine the qualifier of repositories/products/features), I think we should just remove the special treatment of the equinox-launcher fragments here.
Other parts of Tycho or P2 already determine what's contained in a product so we don't have to replicate that logic here again, IMHO.
@laeubi what do you think about just removing the following code entirely?
This would also help if for example in the future no launcher fragments are required at all anymore.

tycho/tycho-core/src/main/java/org/eclipse/tycho/core/osgitools/AbstractArtifactDependencyWalker.java

Lines 126 to 153 in b36b02b

	if (environments != null && product.includeLaunchers()) {
	for (TargetEnvironment environment : environments) {
	String os = environment.getOs();
	String ws = environment.getWs();
	String arch = environment.getArch();
	String id;
	// for Mac OS X there is no org.eclipse.equinox.launcher.carbon.macosx.x86 or org.eclipse.equinox.launcher.carbon.macosx.ppc folder,
	// only a org.eclipse.equinox.launcher.carbon.macosx folder.
	// see https://jira.codehaus.org/browse/MNGECLIPSE-1075
	if (PlatformPropertiesUtils.OS_MACOSX.equals(os) && (PlatformPropertiesUtils.ARCH_X86.equals(arch)
	|| PlatformPropertiesUtils.ARCH_PPC.equals(arch))) {
	id = "org.eclipse.equinox.launcher." + ws + "." + os;
	} else {
	id = "org.eclipse.equinox.launcher." + ws + "." + os + "." + arch;
	}
	if (!bundles.contains(id)) {
	PluginRef ref = new PluginRef("plugin");
	ref.setId(id);
	ref.setOs(os);
	ref.setWs(ws);
	ref.setArch(arch);
	traversePlugin(ref, visitor, visited);
	}
	}
	}

[HannesWell]

@laeubi what do you think about just removing the following code entirely?
This would also help if for example in the future no launcher fragments are required at all anymore.

See #3862. If we decide for the other PR, this one can be closed.