Use original URL to decide if a IU is provided by reference #3849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
added
the
backport-to-tycho-4.0.x
Currently the location of the repository is used, but this can lead to false results if the location is actually is mirrored. In that case a reference is removed even though it contributes to the solution and is afterwards missing. This now uses a Map of the original URI used to load the repository to check for items that can be removed. Beside that a repository does not only contributes its own IUs but also those that are enclosed in their references as well.
Test Results 594 files 594 suites 4h 26m 4s ⏱️ For more details on these failures, see this check. Results for commit a80111b. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the location of the repository is used, but this can lead to false results if the location is actually is mirrored. In that case a reference is removed even though it contributes to the solution and is afterwards missing.
This now uses a Map of the original URI used to load the repository to check for items that can be removed. Beside that a repository does not only contributes its own IUs but also those that are enclosed in their references as well.