Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo for pde.bnd integration with classic Eclipse product build #3845

Merged
merged 1 commit into from
May 17, 2024

Conversation

fipro78
Copy link
Contributor

@fipro78 fipro78 commented May 15, 2024

As discussed in #3823 this PR adds a demo for an Eclipse application project that mixes projects with the classical PDE layout with the new pde.bnd integration layout.

Copy link

github-actions bot commented May 15, 2024

Test Results

  594 files  ±0    594 suites  ±0   3h 58m 24s ⏱️ - 3m 48s
  421 tests ±0    414 ✅ ±0   7 💤 ±0  0 ❌ ±0 
1 263 runs  ±0  1 241 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit 0518209. ± Comparison against base commit 140bc01.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Member

laeubi commented May 16, 2024

@fipro78 would you mind adding the demo here:

https://github.com/eclipse-tycho/tycho/blob/main/tycho-its/src/test/java/org/eclipse/tycho/test/DemoTest.java

that way it will be executed with each build, you can even add some assertions about the resulting product / jars ...

@laeubi
Copy link
Member

laeubi commented May 16, 2024

Maybe you want to add it to the global demo readme as well for easier discovery:

https://github.com/eclipse-tycho/tycho/blob/main/demo/README.md

Also a readme in the demo folder itself would make it easier to guess what the demo is about for example like this:

https://github.com/eclipse-tycho/tycho/blob/main/demo/bnd-pde-workspace/README.md

there you can also reference https://newsroom.eclipse.org/eclipse-newsletter/2023/june/notable-improvements-eclipse-ide#Support-for-Automatic-Manifest-Generation so people can better learn about the feature.

@laeubi
Copy link
Member

laeubi commented May 16, 2024

Maybe "pde-automatic-manifest" would be a better folder name for the demo, bnd is used technically but not everyone will probably will care/know about that.

@laeubi laeubi merged commit f983ce6 into eclipse-tycho:main May 17, 2024
11 checks passed
@laeubi
Copy link
Member

laeubi commented May 17, 2024

@fipro78 many thanks for providing a demo project!

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label May 17, 2024
@eclipse-tycho-bot
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants