fix build warnings and revert compiler workaround #3813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems one test is now failing |
[INFO] Annotation processing is enabled because one or more processors were found on the class path. A future release of javac may disable annotation processing unless at least one processor is specified by name (-processor), or a search path is specified (--processor-path, --processor-module-path), or annotation processing is enabled explicitly (-proc:only, -proc:full). Use -Xlint:-options to suppress this message. Use -proc:none to disable annotation processing.
Unfortunately those values are not interchangeable anymore, when using the release attribute.
The fix has been released in 3.12.1, we depend on 3.13.0 now.
|
I left away the "source/target to release" commit. But I must admit that was just guessing. If it still fails, I will have to run integration tests locally (which I try to avoid). |
|
@Bananeweizen do you want to squash or merge the individual commits? Also for tycho4? |
|
There is nothing that would cause functional changes in Tycho itself, therefore this doesn't need to be ported. I tend to not squash independent changes, even though it means that all except the last have not been tested in isolation. If something comes up later, reverting one of the changes seems easier to me than reverse-engineering the original "splitting" of the squashed commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All commits except the last fix certain warnings that are shown during the build. See the commit messages for details.
The last commit is unrelated in the sense that it reverts a maven compiler workaround. However, sending it as separate PR would lead to a conflict, therefore it has been added here.