Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add follow repository references #3801

Merged

Conversation

tivervac
Copy link
Contributor

Adding support for the new PDE option followRepositoryReferences for .target files.

See https://github.com/eclipse-pde/eclipse.pde/pull/1253/files

@tivervac tivervac force-pushed the add_follow_repository_references branch from 8260858 to 9526f54 Compare April 30, 2024 11:38
Fix typo
@tivervac tivervac force-pushed the add_follow_repository_references branch from 9526f54 to 1b0941d Compare April 30, 2024 11:43
Copy link

github-actions bot commented Apr 30, 2024

Test Results

396 files  ±0  396 suites  ±0   2h 29m 29s ⏱️ -27s
418 tests ±0  410 ✅  - 1   7 💤 ±0  1 ❌ +1 
836 runs  ±0  820 ✅  - 1  15 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 126078f. ± Comparison against base commit fd3e5f8.

♻️ This comment has been updated with latest results.

@tivervac tivervac force-pushed the add_follow_repository_references branch from 1b0941d to accfc94 Compare April 30, 2024 13:55
This is the per-location setting that overrides
TargetPlatformConfiguration#referencedRepositoryMode
@tivervac tivervac force-pushed the add_follow_repository_references branch from accfc94 to 126078f Compare April 30, 2024 13:57
@tivervac
Copy link
Contributor Author

tivervac commented May 2, 2024

@laeubi Do you think I could have caused this test failure on Windows?

2024-04-30T14:44:10.8653597Z [ERROR] org.eclipse.tycho.test.pgp.TestPGPSigning.testSigningSkipIfJarSignedAndAnchored -- Time elapsed: 14.40 s <<< FAILURE!
2024-04-30T14:44:10.8655719Z org.opentest4j.AssertionFailedError: Unexpected unsigned IUs. ==> expected: <[org.eclipse.equinox.common, org.eclipse.equinox.common.source, org.eclipse.osgi, org.eclipse.osgi.source, org.eclipse.platform_root]> but was: <[org.eclipse.equinox.common.source, org.eclipse.osgi, org.eclipse.osgi.source, org.eclipse.platform_root]>
2024-04-30T14:44:10.8657781Z 	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
2024-04-30T14:44:10.8658860Z 	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
2024-04-30T14:44:10.8659757Z 	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
2024-04-30T14:44:10.8660494Z 	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
2024-04-30T14:44:10.8661217Z 	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1156)
2024-04-30T14:44:10.8662123Z 	at org.eclipse.tycho.test.pgp.TestPGPSigning.testSigningSkipIfJarSignedAndAnchored(TestPGPSigning.java:230)
2024-04-30T14:44:10.8663237Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
2024-04-30T14:44:10.8663896Z 

I also don't understand why mac is failing. It says Error: Could not find satisfied version for SemVer '8'.

@laeubi
Copy link
Member

laeubi commented May 2, 2024

The Windows Test is a flapping test and the mac currently lacks a suitable java 8 JVM I'm currently looking into that here:

@tivervac
Copy link
Contributor Author

tivervac commented May 2, 2024

@laeubi In that case, seems like this MR is ready :D

@laeubi
Copy link
Member

laeubi commented May 2, 2024

Do you want to squash the changes or should I merge the individual commits?

@tivervac
Copy link
Contributor Author

tivervac commented May 2, 2024

Do you want to squash the changes or should I merge the individual commits?

I'd like to keep the three separate commits

@laeubi laeubi merged commit c052150 into eclipse-tycho:main May 3, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants