[backport] Transitive dependency projects are not discovered with --also-make #3720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it can happen that if one selects a project with -pl / -am this project has initially not any maven dependencies but then later on tycho adds one as a dependency and then the one declared in the pom are not found. This now adds an additional step each time a project is added as a dependency to look if that project also has maven dependencies that map to reactor projects.
laeubi
changed the title
Test Results 591 files ±0 591 suites ±0 3h 45m 37s ⏱️ - 14m 20s For more details on these failures, see this check. Results for commit 45cf05f. ± Comparison against base commit 42d40a9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it can happen that if one selects a project with -pl / -am this project has initially not any maven dependencies but then later on tycho adds one as a dependency and then the one declared in the pom are not found.
This now adds an additional step each time a project is added as a dependency to look if that project also has maven dependencies that map to reactor projects.
This also includes some fixups to the readme and changelog of the 4.x branch.