Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning about unspecified environment #3390

Merged

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Jan 19, 2024

Currently if not target platform environment is specified Tycho emits a warning "No explicit target runtime environment configuration. Build is platform dependent." beside from that nothing ever seems go wrong and actually Tycho builds can be environment agnostic. Also there is not really a way to tell Tycho that it is okay, so either the user has to use a specific one or configure many ones that make resolving slower.

This now removes this warning, if with modern Tycho there are any problems that arise from a missing environment configuration one should better give a specific error/hint at this place instead of warn "just in case".

Currently if not target platform environment is specified Tycho emits a
warning "No explicit target runtime environment configuration. Build is
platform dependent." beside from that nothing ever seems go wrong and
actually Tycho builds *can* be environment agnostic. Also there is not
really a way to tell Tycho that it is okay, so either the user has to
use a specific one or configure many ones that make resolving slower.

This now removes this warning, if with modern Tycho there are any
problems that arise from a missing environment configuration one should
better give a specific error/hint at this place instead of warn "just in
case".
@laeubi laeubi requested a review from akurtakov January 19, 2024 15:13
@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Jan 19, 2024
Copy link

Test Results

  579 files  ±0    579 suites  ±0   3h 52m 53s ⏱️ +3s
  384 tests ±0    377 ✅ ±0   7 💤 ±0  0 ❌ ±0 
1 152 runs  ±0  1 130 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit 2b81c6b. ± Comparison against base commit e5463f5.

Copy link
Member

@akurtakov akurtakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akurtakov akurtakov merged commit 8395720 into eclipse-tycho:main Jan 20, 2024
11 checks passed
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants