Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include the projects resolved target platform as a source #3389

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Jan 19, 2024

No description provided.

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Jan 19, 2024
Copy link

github-actions bot commented Jan 19, 2024

Test Results

  579 files  ±0    579 suites  ±0   3h 35m 4s ⏱️ - 17m 46s
  384 tests ±0    377 ✅ ±0   7 💤 ±0  0 ❌ ±0 
1 152 runs  ±0  1 130 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit 85365cd. ± Comparison against base commit e5463f5.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Member Author

laeubi commented Jan 19, 2024

FYI @akurtakov @merks I decided to copy the (Permissive)Slicer classes to Tycho code base now as it seems it becomes more and more complicated to keep them managed by P2 and trying to keep backward compatibility with changes needed for Tycho. Given that changes are really seldom on these classes (and mostly introduced by Tycho) this seems the bes way forward for me.

This also allows to apply bugfixes immediately instead of waiting for a P2 release for the cost of probably apply these seldom tings at two places.

@laeubi laeubi force-pushed the make_full_target_aviabble branch 2 times, most recently from 18f214c to df6f44f Compare January 19, 2024 17:59
@laeubi laeubi force-pushed the make_full_target_aviabble branch from df6f44f to 85365cd Compare January 19, 2024 17:59
@laeubi laeubi merged commit 6b9cefe into eclipse-tycho:main Jan 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant