Also consider profile properties when looking for disable mirror keys

[laeubi]

I also created

• Support properties supplied by an agent eclipse-equinox/p2#431

as currently Tycho does ignore any mirrors (by modify the repository under the hood), but the mirror list is still loaded in such a case!

Replaces:

• Checking for value instead of key in #3378

[github-actions]

Test Results

  579 files  ±0    579 suites  ±0   3h 36m 47s ⏱️ - 33m 5s
  384 tests ±0    377 ✅ ±0   7 💤 ±0  0 ❌ ±0 
1 152 runs  ±0  1 130 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit d31c3d9. ± Comparison against base commit 253632e.

[laeubi]

@vogella @Phillipus please validate

[Phillipus]

@laeubi I've tested this with both options tycho.disableP2Mirrors and eclipse.p2.mirrors in my settings.xml file and profile and it is working as expected.

Thanks for this, sorry I didn't take it further in the original PR, your implementation is much better than what I would have done!

[laeubi]

Backported here:

• [backport] Also consider profile properties when looking for disable mirror keys #3387

[vogella]

Thanks @laeubi for fixing it and @Phillipus for identifying the issue and helping with testing it.

You guys are cool.