Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible NPE in AbstractApplication as seen in integration tests #3016

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix possible NPE in AbstractApplication as seen in integration tests #3016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tycho-core/src/main/java/org/eclipse/tycho/p2tools/copiedfromp2/AbstractApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,19 @@ public IArtifactRepository getCompositeArtifactRepository() {
}

public boolean hasArtifactSources() {
return ((ICompositeRepository<?>) getCompositeArtifactRepository()).getChildren().size() > 0;
IArtifactRepository repository = getCompositeArtifactRepository();
if (repository instanceof ICompositeRepository<?> composite) {
return composite.getChildren().size() > 0;
}
return false;
}

public boolean hasMetadataSources() {
return ((ICompositeRepository<?>) getCompositeMetadataRepository()).getChildren().size() > 0;
IMetadataRepository repository = getCompositeMetadataRepository();
if (repository instanceof ICompositeRepository<?> composite) {
return composite.getChildren().size() > 0;
}
return false;
}

public abstract IStatus run(IProgressMonitor monitor) throws ProvisionException;
Expand Down
Loading