Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean resources from previous build's volatiles (#2946) #2949

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

basilevs
Copy link
Contributor

Fixes #2946

When test projects for tycho-compiler-plugin are built, their directories are polluted with build
results. This makes tests using those project unreliable. In particular Eclipse build puts compiled classes in bin directory of test projects, causing #2946.

This change removes some of the pollution to stabilize subsequent tests.

Fixes eclipse-tycho#2946

When test projects are built, their directories are polluted with build
results. This makes tests using those project unreliable.

This change removes some of the pollution to stabilize subsequent tests.
Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an interesting way, so lets try that out if the build passes.

@basilevs basilevs marked this pull request as ready for review October 22, 2023 14:37
@laeubi laeubi merged commit a8dae1a into eclipse-tycho:master Oct 22, 2023
6 of 7 checks passed
@basilevs basilevs deleted the issue_2946 branch October 22, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tycho-compiler-plugin tests fail on MacOS
2 participants