disable vm install job in jdt #2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -162,6 +162,7 @@ public void execute() throws MojoExecutionException, MojoFailureException { | |||
| } catch (Exception e) { | |||
| throw new MojoFailureException("Can't fetch dependencies!", e); | |||
| } | |||
| System.setProperty("DetectVMInstallationsJob.disabled", "true"); | |||
There was a problem hiding this comment.
This can be too late, not sure at which point in time this code is triggered...
There was a problem hiding this comment.
This code is triggered (job is scheduled) when the jdt.launching bundle starts, which can be pretty early as it's required by jdt.core to resolve the classpath IIRC.
Wouldn't it be possible to set the flag before starting the VM (or at least the Equinox container) ?
There was a problem hiding this comment.
- This is before Equinox Container starts
- I now using the preference instead (so no unforeseen side effects)
- I have debugged that this prevents the job from being started.
So if setting it on the Jenkins Job directly works as system-property, this should then work here as well.
laeubi
force-pushed
the
disable_DetectVMInstallationsJob
branch
from
3c05780 to
0a6547c
Compare
laeubi
force-pushed
the
disable_DetectVMInstallationsJob
branch
from
0a6547c to
9e400fc
Compare
laeubi
added
the
backport-to-tycho-4.0.x
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See eclipse-pde/eclipse.pde#782 (comment)